[Kde-pim] Review Request: 100% ok terminated agents

[Jaime Torres Amate]

> On Sept. 13, 2011, 10:09 a.m., Sergio Luis Martins wrote:
> > Can you post a backtrace of the crash you are trying to fix?
> > 
> > There was a crash when akonadi_agent_launcher exited, and that got solved in: http://bugs.kde.org/261788
> > Aparently, the slow shutdown issue also got solved.

Yes, you're right. Until today, the tests I did starting/stoping with a revision older than yours, showed in the console output:
QProcess: Destroyed while process is still running.
And after I applied this patch I didn't got it (until today :-( ).

Forget about the bug.

This patch is only about very small optimization.


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102545/#review6477
-----------------------------------------------------------


On Sept. 13, 2011, 7:42 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102545/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 7:42 a.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Summary
> -------
> 
> Also a little optimization, to check an std::structure emptiness using empty() instead of size()==0.
> 
> 
> This addresses bug 248287.
>     http://bugs.kde.org/show_bug.cgi?id=248287
> 
> 
> Diffs
> -----
> 
>   agentserver/agentserver.cpp 604f59b 
>   server/src/akonadiconnection.h a20209f 
>   server/src/preprocessorinstance.cpp b1de61e 
> 
> Diff: http://git.reviewboard.kde.org/r/102545/diff
> 
> 
> Testing
> -------
> 
> Before, running akonadictl stop, 10% crashes in some agents.
> After, running akonadictl stop, 0% crashes.
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/