[Kde-pim] Review Request: Load translation catalog akonadicontact for EmailAddressSelectionWidget

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102415/#review6258
-----------------------------------------------------------

Ship it!


Looks good to me. An alternative approach might be to use KCatalogLoader, that solves the problem of finding the right place to put the loading code.

- Volker


On Aug. 23, 2011, 2:47 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102415/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2011, 2:47 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> translations are extracted, but not loaded at runtime
> 
> 
> This addresses bug 274547.
>     http://bugs.kde.org/show_bug.cgi?id=274547
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/emailaddressselectionwidget.cpp dfb3e4f 
> 
> Diff: http://git.reviewboard.kde.org/r/102415/diff
> 
> 
> Testing
> -------
> 
> checked with locale de
> 
> 
> Thanks,
> 
> Burkhard
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/