[Kde-pim] Review Request: 100% ok terminated agents

Jaime Torres Amate jtamate at gmail.com
Tue Sep 6 16:53:30 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102545/
-----------------------------------------------------------

Review request for Akonadi.


Summary
-------

In the AgentServer destructor, set m_quiting to true to avoid a crash caused by the Q_ASSERTION in quit().

Also a little optimization, to check an std::structure emptiness using empty() instead of size()==0.


Diffs
-----

  agentserver/agentserver.cpp 604f59b 
  server/src/preprocessorinstance.cpp b1de61e 

Diff: http://git.reviewboard.kde.org/r/102545/diff


Testing
-------

Before, running akonadictl stop, 10% crashes in some agents.
After, running akonadictl stop, 0% crashes.


Thanks,

Jaime Torres

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list