[Kde-pim] Review Request: Implementation of an accessible interface for MessageViewer::MailWebView

[José Millán Soto]

> On Sept. 22, 2011, 5:02 p.m., Commit Hook wrote:
> > This review has been submitted with commit f5247b70b5b0a63d96842a88d79b5ef20546821f by José Millán Soto to branch master.
> 
> Milian Wolff wrote:
>     this does not build, as seen on IRC and when I tried it myself:
>     
>     [23:08] <cmollekopf> /home/chrigi/devel/kde/kdepim/messageviewer/a11y/accessiblemailwebview.cpp: In member function ‘virtual int AccessibleMailWebView::selectionCount()’:
>     [23:08] <cmollekopf> /home/chrigi/devel/kde/kdepim/messageviewer/a11y/accessiblemailwebview.cpp:46:20: error: ‘class MessageViewer::MailWebView’ has no member named ‘hasSelection’

Commit ddbce26141b95d72ab83e2026b2167ea444b09a3 should solve build issues.
http://commits.kde.org/kdepim/ddbce26141b95d72ab83e2026b2167ea444b09a3


- José


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102410/#review6731
-----------------------------------------------------------


On Aug. 23, 2011, 3:19 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102410/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2011, 3:19 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> This patch has an accessible interface for MessageViewer::MailWebView.
> 
> The functionality of this interface is very limited by now, giving only information of the text content to the accessibility tools, but can be useful until a better accessible interface for QWebView or KWebView is avaliable.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 76d8735 
>   a11y/CMakeLists.txt PRE-CREATION 
>   a11y/accessiblemailwebview.h PRE-CREATION 
>   a11y/accessiblemailwebview.cpp PRE-CREATION 
>   a11y/kdepimaccessiblewidgetfactory.h PRE-CREATION 
>   a11y/kdepimaccessiblewidgetfactory.cpp PRE-CREATION 
>   a11y/tests/CMakeLists.txt PRE-CREATION 
>   a11y/tests/accessiblemailwebviewtest.h PRE-CREATION 
>   a11y/tests/accessiblemailwebviewtest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102410/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/