[Kde-pim] Review Request: 100% ok terminated agents

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102545/
-----------------------------------------------------------

(Updated Sept. 12, 2011, 9:41 a.m.)


Review request for Akonadi.


Changes
-------

Looks like I'll never read in the right way the assertions :'(
I still get 100% with this second version.
Changed qDebug to akDebug (and removed m_quiting=true).
removed (it will be removed in the patch to push) the mutable modifier as there is not any constant method that modifies that member.


Summary (updated)
-------

Also a little optimization, to check an std::structure emptiness using empty() instead of size()==0.


Diffs (updated)
-----

  agentserver/agentserver.cpp 604f59b 
  server/src/akonadiconnection.h a20209f 
  server/src/preprocessorinstance.cpp b1de61e 

Diff: http://git.reviewboard.kde.org/r/102545/diff


Testing
-------

Before, running akonadictl stop, 10% crashes in some agents.
After, running akonadictl stop, 0% crashes.


Thanks,

Jaime Torres

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/