[Kde-pim] Review Request: kmail: now it is allowed to create a new folder on the top of an imap folder

[Valentin Rusu]

> On Sept. 22, 2011, 5:30 p.m., Kevin Ottens wrote:
> > resources/imap/addcollectiontask.cpp, line 45
> > <http://git.reviewboard.kde.org/r/102031/diff/2/?file=36557#file36557line45>
> >
> >     We can't assume the separator will always be '/' at the top level, it's likely to be wrong on some servers.
> >     
> >     If the NAMESPACES extension is supported we can sense it from the empty namespace. If not, I'm not sure how to reliably detect it... one would have to dive in the RFC I think.
> 
> Antonis Tsiapaliokas wrote:
>     NAMESPACES extension? RFC? I don't understand these terms.
>     Could you tell some more information because i don't have a clue about them... 
>     
>     But i have another idea. Since we have a collection, we could fetch it(collectionFetchJob), and if this is a top  folder, then we could use the seperator of a subfolder, if it exists, if not, then we will disable the "Add folder" option on kmail. Else, if it is a subfolder, we will use  the "const QChar separator = parentCollection().remoteId().at( 0 );"
>     
>

RFC == Request For Comment == IETF Standard
IMAP servers and clients are supposed to follow RFC3501:
http://tools.ietf.org/rfc/rfc3501.txt


- Valentin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102031/#review6733
-----------------------------------------------------------


On Sept. 20, 2011, 3:37 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102031/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 3:37 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> On kmail 2, if you try to add a folder under your top imap folder, you will see that the button "Add folder" is disable. This patch is fixing this issue.
> 
> 
> This addresses bug 251704.
>     http://bugs.kde.org/show_bug.cgi?id=251704
> 
> 
> Diffs
> -----
> 
>   resources/imap/addcollectiontask.h de83683 
>   resources/imap/addcollectiontask.cpp 81c7dd9 
>   resources/imap/retrievecollectionstask.cpp e86a2ba 
> 
> Diff: http://git.reviewboard.kde.org/r/102031/diff
> 
> 
> Testing
> -------
> 
> Kdepim and kdepim-runtime compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/