[Kde-pim] Review Request: Enable contact filtering by email address availabillity

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102619/#review6687
-----------------------------------------------------------



akonadi/contact/contactsfilterproxymodel.h
<http://git.reviewboard.kde.org/r/102619/#comment5914>

    I am not sure we need a flag for using the filter string. If one doesn't want filtering by string one just wouldn't set one.



akonadi/contact/contactsfilterproxymodel.h
<http://git.reviewboard.kde.org/r/102619/#comment5915>

    Maybe RequireEmail or (Has)AnyEmail.
    It doesn't check for validity of the address



akonadi/contact/contactsfilterproxymodel.h
<http://git.reviewboard.kde.org/r/102619/#comment5916>

    Have a look at Q_FLAGS. Preferable over int (int of course is techically correct as well)



akonadi/contact/contactsfilterproxymodel.cpp
<http://git.reviewboard.kde.org/r/102619/#comment5917>

    I am not sure about operator precenence here. Is '&' stronger than '!' ?
    Otherwise this check if
    (!d->flags) & FilterString
    
    Better use explicit parentheses


- Kevin


On Sept. 20, 2011, 11:17 p.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102619/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 11:17 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> Adds an option to ContactsFilterProxyModel to filter out contacts with no email addresses. This is useful in the EmailAddressSelectionWidget which, as its name suggests, should only show contacts with email addresses.
> 
> 
> This addresses bug 250242.
>     http://bugs.kde.org/show_bug.cgi?id=250242
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactsfilterproxymodel.h 416869b 
>   akonadi/contact/contactsfilterproxymodel.cpp eecc220 
>   akonadi/contact/emailaddressselectionwidget.cpp fc7ec44 
> 
> Diff: http://git.reviewboard.kde.org/r/102619/diff
> 
> 
> Testing
> -------
> 
> created contacts with and without email addresses. As expected, those without didn't appear in the messagecomposer address selection widget.
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/