[Kde-pim] Review Request: Hook ICalTimeZones to Incidence Writers

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102838/
-----------------------------------------------------------

(Updated Oct. 21, 2011, 3:47 a.m.)


Review request for KDEPIM-Libraries.


Changes
-------

New version of the patch: same idea but using existing code and variable names to be more uniform.


Description
-------

iCal Timezone information was being dropped because incidence writers were not able to communicate what timezones had been used in the incidences. This patch hooks timezone lists to the calls to incidence writers and prints the list of timezones used.


This addresses bug 68345.
    http://bugs.kde.org/show_bug.cgi?id=68345


Diffs (updated)
-----

  kcalcore/icalformat.cpp 105efc5 
  kcalcore/icalformat_p.h ec63586 
  kcalcore/icalformat_p.cpp 5938d02 

Diff: http://git.reviewboard.kde.org/r/102838/diff/diff


Testing
-------

First of all, I've not done enough testing - I'm submitting this patch to get initial reviews and comments. This is how I reproduce the original bug report:

1. Use an iCal event that defines a "custom" timezone (see, e.g. https://bugs.kde.org/attachment.cgi?id=63679)
2. Load it into KOrganizer/Akonadi or serialize it through code

Missing tests:

1. Find other writers affected in a similar way
2. Test with many different iCal resources that define custom calendars


Thanks,

David Narváez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/