[Kde-pim] Review Request: Allow Incidence Editor to Handle Additional TimeZones

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102945/
-----------------------------------------------------------

(Updated Oct. 23, 2011, 4:47 p.m.)


Review request for KDEPIM.


Changes
-------

Adding const to most of the variables and fixing code style of else. I didn't address the issue about the spec variables because I use the spec variable to determine if it's in fact a TimeZone spec or not. Since it's just a code style issue, I'm not willing to put a fight over this :) so if it's better, I can change it to get the timezone variable itself instead of the spec.


Description
-------

If the incidence has a time zone not included in the system timezones, add it to the TimeZone box.


Diffs (updated)
-----

  incidenceeditor-ng/incidencedatetime.cpp ff3fdc3 
  incidenceeditor-ng/ktimezonecombobox.cpp 7fbfef1 

Diff: http://git.reviewboard.kde.org/r/102945/diff/diff


Testing
-------

1. In KOrganizer, add an event with local timezone
2. In KOrganizer, add the event located here https://bugs.kde.org/attachment.cgi?id=63679
3. Edit both events and notice the Time Zones displayed in the boxes - one is local time zone and the other one is called "Eastern Standard Time" time zone

You currently need review request 102838 to be able to do step 2 correctly.


Thanks,

David Narváez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/