[Kde-pim] Review Request: Revise warning message to be more accurate

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102796/#review7569
-----------------------------------------------------------


Any comments on this?

- David Jarvie


On Oct. 6, 2011, 9:57 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102796/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2011, 9:57 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Whenever its file is changed by an external process, SingleFileResourceBase::fileChanged() saves the previous version of the file to another directory. It also outputs the following warning message:
> 
> The file '%1' was changed on disk while there were still pending changes in Akonadi. To avoid data loss, a backup of the internal changes has been created at '%2'.
> 
> The message is AFAICS misleading - it saves the file regardless of whether there are any pending Akonadi changes. It has led me to waste time trying to track down what changes were in progress, when a different message could have reassured me that it was just saving the file as (I presume) a precaution. I therefore suggest an alternative, less misleading, warning message.
> 
> 
> Diffs
> -----
> 
>   resources/shared/singlefileresourcebase.cpp 51e0f79 
> 
> Diff: http://git.reviewboard.kde.org/r/102796/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/