[Kde-pim] Review Request: avoid the use of an undefined collection

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102765/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Description
-------

Within the file
  kdepimlibs/akonadi/specialcollectionshelperjobs.cpp
at the method:
  DefaultResourceJobPrivate::collectionFetchResult( KJob *job )
I found a problem: if the job has no collection, info is given with
  collections.count()
the loop
  foreach ( const Collection &collection, collections ) {
will not be entered. The variable 
  resourceCollection
is declared but nothing is assigned to it.
I think, it is not allowed to use it, such as a few lines below
  if ( !resourceCollection.isValid() ) {

My proposal: 
Test the count, and just return if zero.


Diffs
-----

  akonadi/specialcollectionshelperjobs.cpp ebc79c3 

Diff: http://git.reviewboard.kde.org/r/102765/diff/diff


Testing
-------


Thanks,

Guy Maurel

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/