[Kde-pim] Review Request: Make collection ID available to resources derived from SingleFileResource

[David Jarvie]

> On Sept. 29, 2011, 7:02 p.m., Kevin Krammer wrote:
> > I am not sure this is necessary.
> > I think the resource can address its collection(s) just by remoteId.
> > 
> > Can you try using CollectionModifyJob with a collection with the single file resource's remoteId set?

I tried replacing Collection(collectionId()) (which uses my proposed patch) with the following, but it doesn't work:

Collection c;
c.setParentCollection(Collection::root());
c.setRemoteId(mSettings->path());

Is there more which needs to be done to set up the Collection so that CollectionModifyJob will work?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102706/#review6921
-----------------------------------------------------------


On Sept. 25, 2011, 10:22 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102706/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2011, 10:22 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The KAlarm single file resource needs to know its collection ID in order to be able to update collection attributes when settings change. This patch stores the collection ID when retrieveItems() is called during resource initialisation, and provides a method to fetch it.
> 
> 
> Diffs
> -----
> 
>   resources/ical/shared/icalresourcebase.cpp 9b59562 
>   resources/shared/singlefileresource.h 4ea0554 
> 
> Diff: http://git.reviewboard.kde.org/r/102706/diff/diff
> 
> 
> Testing
> -------
> 
> Works with KAlarmResource (currently in kdepim/kalarm).
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/