[Kde-pim] Review Request: avoid the use of an undefined collection

[Kevin Krammer]

On Tuesday, 2011-10-11, Guy Maurel wrote:
> Hello Kevin!
> 
> I found something that doesn't meet your prediction, please look under:
> 
> On Sunday, October 09, 2011 04:46:43 PM Kevin Krammer wrote:
> > On Wednesday, 2011-10-05, Guy Maurel wrote:
> > > I see the problem at file
> > > kdepimlibs/akonadi/specialcollectionshelperjobs.cpp at line 419:
> > > q->emitResult();
> 
> ...
> 
> > With the context you have provided (outboxqueue requesting outbox
> > folder), I did a bit of digging.
> > 
> > The code creating and running the DefaultResourceJob expects it either to
> > deliver all special collections it could find but at least the resource's
> > top level collection so it can create all missing ones.
> > 
> > Returning from DefaultResourceJobPrivate::collectionFetchResult() without
> > an error *and* without a valid top level collection violates that
> > expectation. (A debug build should actually assert in
> > SpecialCollectionsRequestJobPrivate::createRequestedFolders(),
> 
> I never got here!
> Where should it comes from?

In SpecialCollectionsRequestJobPrivate::resourceScanResult when the job has no 
error, either of the two following paths calls createRequestedFolder.

In our case, where we have a DefaultResourceJob, resourceScanResult is 
connected to the job when it is created in 
SpecialCollectionsRequestJobPrivate::lockResult.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20111017/f858dfcf/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/