[Kde-pim] Review Request: Allow Incidence Editor to Handle Additional TimeZones

[David Narváez]

> On Oct. 23, 2011, 8:22 a.m., Kevin Krammer wrote:
> > incidenceeditor-ng/incidencedatetime.cpp, line 739
> > <http://git.reviewboard.kde.org/r/102945/diff/1/?file=39513#file39513line739>
> >
> >     Assuming setDateTimes could be called multiple times (e.g. by accident), maybe check if mTimesZones already contains the value?

Internally, mTimeZones is a map. Not only will it check for existance but it will merge data from the new time zone into the time zone already included in the map which will make the timezone uniform in the (strange) corner case that both the start and end timezones are named the same but specified differently. Sounds good?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102945/#review7547
-----------------------------------------------------------


On Oct. 23, 2011, 1:40 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102945/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 1:40 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> If the incidence has a time zone not included in the system timezones, add it to the TimeZone box.
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidencedatetime.cpp ff3fdc3 
>   incidenceeditor-ng/ktimezonecombobox.cpp 7fbfef1 
> 
> Diff: http://git.reviewboard.kde.org/r/102945/diff/diff
> 
> 
> Testing
> -------
> 
> 1. In KOrganizer, add an event with local timezone
> 2. In KOrganizer, add the event located here https://bugs.kde.org/attachment.cgi?id=63679
> 3. Edit both events and notice the Time Zones displayed in the boxes - one is local time zone and the other one is called "Eastern Standard Time" time zone
> 
> You currently need review request 102838 to be able to do step 2 correctly.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/