[Kde-pim] Review Request: Fix kontact crash

[Ingo Klöcker]

> On Oct. 6, 2011, 5:21 p.m., Allen Winter wrote:
> > Ship It!
> 
> Laurent Montel wrote:
>     Perhaps it will good to know why mGuiClient is null before to commit no ?
>

I agree with Laurent. If mGuiClient really can be null then another check has to be added in createActions(). OTOH, if mGuiClient is not expected to be null then we should not add code (a null pointer check) that tries to handle an invalid state of the application. This would just make it worse. Instead we should find out why the application is in an invalid state.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102787/#review7154
-----------------------------------------------------------


On Oct. 6, 2011, 2:21 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102787/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2011, 2:21 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> When I start KMail here it runs ok, but if I run kontact it crashes with attached backtrace.  Adding a check for mGUIClient before dereferencing it when clearing the actions in the TagActionManager fixes the crash, though I'm not sure why the mGUIClient would ever be invalid, as it's passed into the ctor.
> 
> 
> Diffs
> -----
> 
>   kmail/tagactionmanager.cpp 8ada2ea 
> 
> Diff: http://git.reviewboard.kde.org/r/102787/diff/diff
> 
> 
> Testing
> -------
> 
> I have been able to successfully launch kontact a few times since I added this small patch.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/