[Kde-pim] Review Request: Allow Incidence Editor to Handle Additional TimeZones

[David Jarvie]

> On Oct. 31, 2011, 3:19 p.m., Sergio Luis Martins wrote:
> > When you click on "time zones >>", in the editor, how long does it take to show the combos?
> > 
> > Here it takes like 0 ( unpatched ) and 1 second ( patched ). I haven't profiled it but I suspect reading the system timezones 4 times in fillCombo() is the culprit.
> > 
> > We could have a member variable with the system timezones so it only gets read once.
> 
> David Narváez wrote:
>     Indeed it's not fast. I'm going to try the member variable solution and update the  patch.

Reading the system time zones 4 times won't involve accessing the system time zone database more than once. Once KSystemTimeZone has read the system time zone database, it just stores the results and doesn't read it again. So KSystemTimeZone::zones() doesn't reread the system database.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102945/#review7774
-----------------------------------------------------------


On Oct. 31, 2011, 8:41 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102945/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 8:41 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> If the incidence has a time zone not included in the system timezones, add it to the TimeZone box.
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidencedatetime.cpp ff3fdc3 
>   incidenceeditor-ng/ktimezonecombobox.cpp 7fbfef1 
> 
> Diff: http://git.reviewboard.kde.org/r/102945/diff/diff
> 
> 
> Testing
> -------
> 
> 1. In KOrganizer, add an event with local timezone
> 2. In KOrganizer, add the event located here https://bugs.kde.org/attachment.cgi?id=63679
> 3. Edit both events and notice the Time Zones displayed in the boxes - one is local time zone and the other one is called "Eastern Standard Time" time zone
> 
> You currently need review request 102838 to be able to do step 2 correctly.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/