[Kde-pim] Review Request: imap resource: Should call AgentBase::setNeedsNetwork() in the ctor
Commit Hook
null at kde.org
Mon Nov 14 20:43:13 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103112/#review8199
-----------------------------------------------------------
This review has been submitted with commit b62d1bf7e5e856a5845140aaf2e740bb71e50956 by Sergio Martins to branch KDE/4.7.
- Commit Hook
On Nov. 12, 2011, 6:50 a.m., Sergio Luis Martins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103112/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2011, 6:50 a.m.)
>
>
> Review request for KDEPIM.
>
>
> Description
> -------
>
> The imap resource doesn't call AgentBase::setNeedsNetwork() unless you use the configuration dialog.
>
> Right now, when the network goes down, the resource continues online and tries to retrieve mail, then hangs on an error state until you toggle "Work offline" in kmail.
>
> This patch fixes that.
>
>
> Diffs
> -----
>
> resources/imap/imapresource.cpp 46dbad4
>
> Diff: http://git.reviewboard.kde.org/r/103112/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Luis Martins
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list