[Kde-pim] Patch for kdepim bug 263587

[Allen Winter]

On Monday 28 November 2011 5:03:41 PM Ingo Klöcker wrote:
> On Saturday 26 November 2011, Allen Winter wrote:
> > On Friday 25 November 2011 8:47:18 AM Peter Pille wrote:
> > > Hi,
> > > 
> > > I prepared a patch for the bug 263587, which is attached.
> > > 
> > > The drawback of this patch is, that you will not see the BCC
> > > receipients in the 'Sent' folder anymore.
> > > 
> > > I'm new to kdepim programing and have unfortunately not much time
> > > at the moment to investigate further. But I think this patch is
> > > better than nothing.
> > 
> > I was just about to press the commit button on your patch -- about 1
> > week ago.
> > 
> > Then I discussed your patch with Laurent.  He didn't like the patch
> > because it causes Bcc info to be lost in the situation where mail
> > needs to be resent. Like if the mail dispatcher agent is down.
> 
> Laurent is right.
> 
> 
> > So then we decided to make the smtp ioslave do the work of removing
> > the Bcc from the header before sending.
> 
> Hmm. Seems wrong. The SMTP ioslave shouldn't mess around with the 
> message. It should just send it. Another reason against doing it in the 
> SMTP ioslave is that the BCC-removal code would need to be duplicated 
> for sending via sendmail.
> 
> 
> > I started looking at doing that but got side-tracked onto other
> > things.
> > 
> > If someone else wants to have a go at the smtop ioslave please go
> > ahead.
> > 
> > perhaps our thinking is wrong -- if so, Laurent needs to be
> > convinced.
> 
> To me the mail dispatcher agent appears to be the more logical place for 
> stripping the BCC header, just before passing the message to the service 
> doing the actual sending. In fact, that's exactly what KMail1 did in 
> KMSender::doSendMsg() just before passing the message to the transport 
> job.
> 
Yep, this is the definitive solution.
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/