[Kde-pim] Re: Review Request: Add FreeBusyProvider base classes

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101296/#review3275
-----------------------------------------------------------



akonadi/kcal/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101296/#comment2745>

    I think all public headers have an additional uppercase variant in kdepimlibs/include



akonadi/kcal/freebusyproviderbase.h
<http://git.reviewboard.kde.org/r/101296/#comment2743>

    Can this be const?



akonadi/kcal/freebusyproviderbase.h
<http://git.reviewboard.kde.org/r/101296/#comment2744>

    const?


- Kevin


On May 5, 2011, 10:07 p.m., Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101296/
> -----------------------------------------------------------
> 
> (Updated May 5, 2011, 10:07 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> Following Osnabrück meeting I implemented the next method of free-busy support into KDEPIM. This patch adds the base classes necessary for other changes that will go in kdepim.
> 
> In short those classes must be inherited by a resource that provides free-busy information, and add it a D-Bus interface. The resource can then be queried for f-b info.
> 
> This have been commented on in the list, and some improvments were made following feedback.
> 
> 
> Diffs
> -----
> 
>   akonadi/kcal/freebusyproviderbase.h PRE-CREATION 
>   akonadi/interfaces/org.freedesktop.Akonadi.Resource.FreeBusyProvider.xml PRE-CREATION 
>   akonadi/kcal/CMakeLists.txt f53552f 
>   akonadi/kcal/freebusyproviderbase.cpp PRE-CREATION 
>   akonadi/kcal/freebusyproviderbase_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101296/diff
> 
> 
> Testing
> -------
> 
> All tests were done successfully with the DAV resource (review requests to follow in the next days). The f-b info is correctly fetched.
> 
> 
> Thanks,
> 
> Grégory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/