[Kde-pim] Re: Review Request: Formatted address support for locales gb, be, it, gr, nz, lu

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101311/#review3235
-----------------------------------------------------------

Ship it!


Looks good to me as KLocale co-maintainer.  More of these would be great, is there any way to script obtaining the formats, or is it a slow manual process?  

If you do more, feel free to just commit them after testing as I automatically get a cc of the commit for review.

Thanks!

- John


On May 7, 2011, 3:03 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101311/
> -----------------------------------------------------------
> 
> (Updated May 7, 2011, 3:03 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> This patch adds formatted address support for the following locales: gb, be, it, gr, nz, lu.  This is of course not a comprehensive list of locales that need such information; they merely correspond to addresses that I have in my personal address book and which print a "no format for locale" message on stderr when displaying them.
> 
> The formats are derived from from the UPU addressing standards for those countries which can be found at
> http://www.upu.int/en/activities/addressing/postal-addressing-systems-in-member-countries.html
> 
> (Submitting to 'kdepimlibs' group for review because this is the main consumer of this data from these files, there seems to be no L10N review group)
> 
> 
> Diffs
> -----
> 
>   l10n/be/entry.desktop afc5a77 
>   l10n/gb/entry.desktop 3154344 
>   l10n/gr/entry.desktop 03ccfcd 
>   l10n/it/entry.desktop f31bca7 
>   l10n/lu/entry.desktop a4304da 
>   l10n/nz/entry.desktop 7fe527a 
> 
> Diff: http://git.reviewboard.kde.org/r/101311/diff
> 
> 
> Testing
> -------
> 
> Built kderuntime with these changes, checked operation of address display using kaddressbook.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/