[Kde-pim] Re: Review Request: Kmail: Custom drafts and templates are lost

[Kevin Krammer]

> On May 20, 2011, 4:02 p.m., Kevin Krammer wrote:
> > messagecomposer/composerviewbase.cpp, line 928
> > <http://git.reviewboard.kde.org/r/101391/diff/2/?file=16775#file16775line928>
> >
> >     I know this is not part of your change, but overwriting target (which has been initialized with suitable default) without checking looks bad to me.
> >     Should probably be done in an extra review
> 
> Antonis Tsiapaliokas wrote:
>     In case of a custom collection, my patch is checking to find out if the collection exist. Why should we add another check?

I just don't see a point in overwriting target with an invalid collection.


> On May 20, 2011, 4:02 p.m., Kevin Krammer wrote:
> > messagecomposer/composerviewbase.cpp, line 915
> > <http://git.reviewboard.kde.org/r/101391/diff/2/?file=16775#file16775line915>
> >
> >     Since saving becomes asynchronous, it might be better to add the message to the job as a custom property.
> >     Maybe already as an item
> 
> Antonis Tsiapaliokas wrote:
>     We don't have a private Akonadi::Item like we have the m_msg. So how could this be possible? But we can put it together with the Akonadi::CollectionFetchJob.
> 
> Thomas McGuire wrote:
>     Yep, you can store the message in the CollectionFetchJob, use QObject::setProperty()/property() for that.

You can create the item already in this method and the store it on the collection fetch job.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101391/#review3424
-----------------------------------------------------------


On May 20, 2011, 2:55 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101391/
> -----------------------------------------------------------
> 
> (Updated May 20, 2011, 2:55 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> If someone is trying to save a draft or a template mail and the custom collection doesn't exist then the mail is lost. With this patch, if the custom collection doesn't exist then the mail is saved in the default draft and template folders. (Which are created by the Akonadi::SpecialMailCollections)
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerviewbase.h 3b0a315 
>   messagecomposer/composerviewbase.cpp 9a7d5c3 
> 
> Diff: http://git.reviewboard.kde.org/r/101391/diff
> 
> 
> Testing
> -------
> 
> kdepim compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/