[Kde-pim] Re: Review Request: Kmail: Custom drafts and templates are lost

Sergio Luis Martins iamsergio at gmail.com
Fri May 20 15:27:10 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101391/#review3420
-----------------------------------------------------------



messagecomposer/composerviewbase.cpp
<http://git.reviewboard.kde.org/r/101391/#comment2878>

    #include <Akonadi/Collection>



messagecomposer/composerviewbase.cpp
<http://git.reviewboard.kde.org/r/101391/#comment2880>

    Doesn't need QObject::



messagecomposer/composerviewbase.cpp
<http://git.reviewboard.kde.org/r/101391/#comment2881>

    Missing indentation


- Sergio Luis


On May 20, 2011, 2:01 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101391/
> -----------------------------------------------------------
> 
> (Updated May 20, 2011, 2:01 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> If someone is trying to save a draft or a template mail and the custom collection doesn't exist then the mail is lost. With this patch, if the custom collection doesn't exist then the mail is saved in the default draft and template folders. (Which are created by the Akonadi::SpecialMailCollections)
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerviewbase.h 3b0a315 
>   messagecomposer/composerviewbase.cpp 9a7d5c3 
> 
> Diff: http://git.reviewboard.kde.org/r/101391/diff
> 
> 
> Testing
> -------
> 
> kdepim compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list