[Kde-pim] Re: KCalCore + Observers

[David Jarvie]

On Mon, May 9, 2011 3:43 pm, Patrick Ohly wrote:
> On Di, 2011-05-03 at 09:58 +0100, David Jarvie wrote:
>> On Tue, May 3, 2011 8:12 am, Patrick Ohly wrote:
>> > The disadvantage is that the observer classes can be used in apps
>> which
>> > do not use QObject.
>> >
>> > A possible compromise is this:
>> >       * Switch libkcalcore to the signal/slot version of the API,
>> >         removing the register/removeObserver() calls and these
>> Observer
>> >         base classes. Requires adding QObject as base class of some
>> >         classes (ReccurenceRule).
>>
>> Basing classes on QObject would make them unable to be copied, which
>> would break a lot of code.
>
> Wasn't much of the code already changed such that QSharedPointer has to
> be used to hold instances? Is there any class left which can be copied
> by value?

Not all classes currently use QSharedPointer (e.g. Recurrence).

-- 
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/