[Kde-pim] Re: Review Request: Kmail: check fcc collection in the MDA.

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100829/#review2121
-----------------------------------------------------------


Some code style comments, otherwise if Kevin is ok with it ship it.


agents/maildispatcher/sendjob.cpp
<http://git.reviewboard.kde.org/r/100829/#comment1749>

    Might be the reviewboard but otherwise please indent this line.



agents/maildispatcher/sendjob.cpp
<http://git.reviewboard.kde.org/r/100829/#comment1750>

    } else {


- Torgny


On March 10, 2011, 5:38 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100829/
> -----------------------------------------------------------
> 
> (Updated March 10, 2011, 5:38 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This patch is fixing a hole in the MDA. If the fcc folder is deleted when the message is queued, then the mail is lost. With my patch the mail is saving in the default sent-mail collection. I forgot to check for the whitespace... So i update my diff. Sorry for the trouble.
> 
> 
> Diffs
> -----
> 
>   agents/maildispatcher/sendjob.h 8f0cdc8 
>   agents/maildispatcher/sendjob.cpp 8e1fcc1 
> 
> Diff: http://git.reviewboard.kde.org/r/100829/diff
> 
> 
> Testing
> -------
> 
> Kdepim-runtime and kdepim is compiling without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/