[Kde-pim] Re: Review Request: Migrate Akregator from KSystemTrayIcon to KStatusNotifierItem

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100850/#review1978
-----------------------------------------------------------


It seems like you remove any code that was related to the show/hide feature (working or not), is this on purpose, or am I missing something?


akregator/src/actionmanagerimpl.cpp
<http://git.reviewboard.kde.org/r/100850/#comment1663>

    Also please remove any trailing white space (red on reviewboard)



akregator/src/akregator_part.cpp
<http://git.reviewboard.kde.org/r/100850/#comment1664>

    0 not 0L


- Torgny


On March 13, 2011, 5:54 p.m., Theo Chatzimichos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100850/
> -----------------------------------------------------------
> 
> (Updated March 13, 2011, 5:54 p.m.)
> 
> 
> Review request for KDEPIM and Frank Osterfeld.
> 
> 
> Summary
> -------
> 
> Migrate from KSystemTrayIcon to KStatusNotifierItem
>   - Use KIcon instead of QPixmap
>   - Deprecate showPart, seems not to be used, produces a No such signal msg
>   - Replace quitSelected with the signal of KStatusNotifierItem's default quit action
>   - Rearrange some header files for fun :)
> 
> 
> Diffs
> -----
> 
>   akregator/src/actionmanagerimpl.h f794351 
>   akregator/src/actionmanagerimpl.cpp 2a8fc98 
>   akregator/src/akregator_part.cpp 53f02dc 
>   akregator/src/mainwindow.cpp 7d572d5 
>   akregator/src/trayicon.h 281c5f4 
>   akregator/src/trayicon.cpp a6860fa 
>   kontact/plugins/akregator/akregator_plugin.h 6369177 
>   kontact/plugins/akregator/akregator_plugin.cpp b676652 
> 
> Diff: http://git.reviewboard.kde.org/r/100850/diff
> 
> 
> Testing
> -------
> 
> Tested both inside Kontact and as standalone, it seems to work fine:
> the following things work fine:
>  - enable/disable tray icon from settings
>  - enable/disable unread count from settings
>  - close when there is no icon, hide in tray when there is an icon
> 
> Bugs:
>  - start Akregator from Kontact, right click on the icon, the menu says kontact instead of Akregator (minor issue, could be handled in a separate commit)
>  - in kontact, when there is no KMail tray icon and there is tray icon for Akregator, pressing X does not hide kontact to tray (not a regression, the behaviour is still the same before my patch, the bug may be in KMail or in Kontact instead of Akregator)
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/100850/s/98/
> 
> 
> Thanks,
> 
> Theo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/