[Kde-pim] Re: Review Request: Kmail: check fcc collection in the MDA.
Antonis Tsiapaliokas
kok3rs at gmail.com
Wed Mar 23 12:22:01 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100829/
-----------------------------------------------------------
(Updated March 23, 2011, 12:22 p.m.)
Review request for KDEPIM.
Changes
-------
Hello
Thank you for reviewing my patch. There is no coding style issue. My patch is ok. It is a reviewboard issue. I change the "else" line as you told me to do.
Summary
-------
Hello
This patch is fixing a hole in the MDA. If the fcc folder is deleted when the message is queued, then the mail is lost. With my patch the mail is saving in the default sent-mail collection. I forgot to check for the whitespace... So i update my diff. Sorry for the trouble.
Diffs (updated)
-----
agents/maildispatcher/sendjob.h 8f0cdc8
agents/maildispatcher/sendjob.cpp 8e1fcc1
Diff: http://git.reviewboard.kde.org/r/100829/diff
Testing
-------
Kdepim-runtime and kdepim is compiling without any issue.
Thanks,
Antonis
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list