[Kde-pim] Re: Review Request: Add a stateChanged() signal to KIMAP::Session

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100973/#review2263
-----------------------------------------------------------


See comment on the signal signature, otherwise the patch looks like a fine addition.


kimap/session.h
<http://git.reviewboard.kde.org/r/100973/#comment1952>

    What about having the new state as payload of the signal? Maybe also pass the old state as a second parameter?


- Kevin


On March 30, 2011, 9:19 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100973/
> -----------------------------------------------------------
> 
> (Updated March 30, 2011, 9:19 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds a stateChanged() signal to KIMAP::Session, emitted wen the state changes.
> 
> 
> Diffs
> -----
> 
>   kimap/session.h 0d45794 
>   kimap/session.cpp 98972e9 
>   kimap/session_p.h 19cd096 
>   kimap/tests/testsession.cpp 6610a2e 
> 
> Diff: http://git.reviewboard.kde.org/r/100973/diff
> 
> 
> Testing
> -------
> 
> Session-s unit test passes, with new checks to take the changes into account
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/