[Kde-pim] Re: Review Request: Consistent wording between "edit email" and "edit IM" dialogues

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100528/#review1835
-----------------------------------------------------------

Ship it!


Sorry for the delay, good catches!

- Kevin


On Feb. 2, 2011, 8:10 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100528/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 8:10 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> In the KAddressBook application, there is an inconsistency between the editing dialogues for the email addresses and IM contact addresses.  In the dialogue for email the window title says "... Addresses" and the "set as standard" button says "Set Standard".  In the corresponding dialogue for IM the title says "... Address" (even though there can be more than one) and the same button says "Set as Standard".
> 
> This change makes the pluralisation of the window title, and the label of this button, consistent between these two dialogues.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/emaileditwidget.cpp a931ec1 
>   akonadi/contact/editor/im/imeditordialog.cpp 3a2c83f 
> 
> Diff: http://git.reviewboard.kde.org/r/100528/diff
> 
> 
> Testing
> -------
> 
> Built kdepimlibs and ran kaddressbook with these changes, verified the display.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/