[Kde-pim] Re: Review Request: Bugfix in ImapStreamParser::readParenthesizedList(): don't parse characters inside a quoted-string.

[Ingo Klöcker]

> On March 23, 2011, 4:45 p.m., Kevin Ottens wrote:
> > Looks straightforward. Please commit (assuming the unit tests still pass).

Actually, a new unit test should be added for this.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100902/#review2125
-----------------------------------------------------------


On March 22, 2011, 4:15 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100902/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 4:15 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> Fixes crashes and errors due to the fact that ImapStreamParser::readParenthesizedList() doesn't recognizes quoted-strings.
> 
> Without this fix, if the IMAP server sent the following list: "(AA ("BB)" CC))", ImapStreamParser would crash because it would incorrectly interpret the ")" inside the quoted string "BB)" as part of the list.
> 
> 
> Diffs
> -----
> 
>   kimap/imapstreamparser.cpp c09baef 
> 
> Diff: http://git.reviewboard.kde.org/r/100902/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/