[Kde-pim] Re: Review Request: Tag 'emph' is neither semantic nor HTML

[Guy Maurel]

> On March 20, 2011, 5:30 p.m., Ingo Klöcker wrote:
> > Ship it!

No! Not yet.
A new problem occurs because the tag <em> isn't known by kdelibs/kdecore/localization/kuitsemantics.cpp:1074
    // Wrap text with top tag if not explicitly given.
    if (!explicitTopTag) {
        return QLatin1Char('<') + s->tagNames[toptag] + QLatin1Char('>')
               + text_ // original text, not the one possibly stripped above
               + QLatin1String("</") + s->tagNames[toptag] + QLatin1Char('>')
and fill the text with <kuil> at the begin.
This produce a markup error:
kmail2(5578)/kdecore (KLocale) KuitSemanticsPrivate::semanticToVisualText: "Markup error in message {<kuil><b>Thanks for using KMail2!</b><
br/><p>KMail2 uses a new storage technolog...}: Opening and ending tag mismatch..
The tag <b> runs OK.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100890/#review2066
-----------------------------------------------------------


On March 20, 2011, 4:31 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100890/
> -----------------------------------------------------------
> 
> (Updated March 20, 2011, 4:31 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> The tag 'emph' is not HTML.
> I propose to use <b>
> 
> 
> Diffs
> -----
> 
>   kmail/kmkernel.cpp 49d753d 
> 
> Diff: http://git.reviewboard.kde.org/r/100890/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/