[Kde-pim] Re: Review Request: KIMAP::FetchJob: allow to fetch MIME Headers + content of specific parts at the same time

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100824/#review2264
-----------------------------------------------------------

Ship it!


Looks good to me, please see the small adjustment in comment, otherwise ready to push IMO.


kimap/fetchjob.cpp
<http://git.reviewboard.kde.org/r/100824/#comment1953>

    Please adjust the comment, they're obviously not "ditched" anymore. :-)


- Kevin


On March 28, 2011, 9:06 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100824/
> -----------------------------------------------------------
> 
> (Updated March 28, 2011, 9:06 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch makes it easier to implement fetch-on-demand for attachments by allowing to fetch MIME headers + content of specific message parts with only one job. Without this patch, 2 fetchjob would have been needed.
> 
> 
> Diffs
> -----
> 
>   kimap/fetchjob.h 54afd56 
>   kimap/fetchjob.cpp 6cf8953 
>   kimap/tests/fetchjobtest.cpp 7cdd1ee 
> 
> Diff: http://git.reviewboard.kde.org/r/100824/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/