[Kde-pim] Re: Review Request: KIMAP::FetchJob: allow to fetch MIME Headers + content of specific parts at the same time
Kevin Ottens
ervin at kde.org
Wed Mar 23 16:43:48 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100824/#review2124
-----------------------------------------------------------
A minor whitespace issue, otherwise looks good. Any chance you could add unit tests for it? (that's the main reason why I'm not marking it as "ship it".
kimap/fetchjob.h
<http://git.reviewboard.kde.org/r/100824/#comment1755>
Extra whitespace, please remove it.
- Kevin
On March 21, 2011, 8:45 a.m., Gregory Schlomoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100824/
> -----------------------------------------------------------
>
> (Updated March 21, 2011, 8:45 a.m.)
>
>
> Review request for KDEPIM-Libraries and Kevin Ottens.
>
>
> Summary
> -------
>
> This patch makes it easier to implement fetch-on-demand for attachments by allowing to fetch MIME headers + content of specific message parts with only one job. Without this patch, 2 fetchjob would have been needed.
>
>
> Diffs
> -----
>
> kimap/fetchjob.h 54afd56
> kimap/fetchjob.cpp 6cf8953
>
> Diff: http://git.reviewboard.kde.org/r/100824/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregory
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list