[Kde-pim] Re: Review Request: Tag 'emph' is neither semantic nor HTML

[Ingo Klöcker]

On Sunday 20 March 2011, Guy Maurel wrote:
> > On March 20, 2011, 5:30 p.m., Ingo Klöcker wrote:
> > > Ship it!
> 
> No! Not yet.
> A new problem occurs because the tag <em> isn't known by
> kdelibs/kdecore/localization/kuitsemantics.cpp:1074 // Wrap text
> with top tag if not explicitly given.
>     if (!explicitTopTag) {
>         return QLatin1Char('<') + s->tagNames[toptag] +
> QLatin1Char('>') + text_ // original text, not the one possibly
> stripped above + QLatin1String("</") + s->tagNames[toptag] +
> QLatin1Char('>') and fill the text with <kuil> at the begin.
> This produce a markup error:
> kmail2(5578)/kdecore (KLocale)
> KuitSemanticsPrivate::semanticToVisualText: "Markup error in message
> {<kuil><b>Thanks for using KMail2!</b>< br/><p>KMail2 uses a new
> storage technolog...}: Opening and ending tag mismatch..
>
> The tag <b> runs OK.

Hmm. I think I found the real problem for the error message "Opening and 
ending tag mismatch..". There is a </p> missing. See my review.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110320/1735ce05/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/