[Kde-pim] Re: Review Request: ktimetracker - fix saving of running tasks (making behaviour consistent between various modes of closing a file)

[Cristi Posoiu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100950/
-----------------------------------------------------------

(Updated March 26, 2011, 11:34 a.m.)


Review request for KDEPIM.


Summary
-------

Ktimetracker seems to not be consistent with data saved for a *running* task.
that is:
a) add a task. make it running. do a File close. quit Timetracker. Start it. As expected task is loaded and resumed (i.e. running)
b) add a task. make it running. Do a Quit. Start timetracker. Task is not running.

Problem seems to be that in several cases, before saving the data a stopAllTimers() call is done.
Refactored code a bit so that a different function call is used, that just stops timers and calls clearActiveTasks() - without really stopping first the tasks.

By the way, related to this, I understood - see bug 237367 - that resuming tasks is not always wanted. I gave a suggestion in there.


Diffs
-----

  ktimetracker/taskview.h 3e73aa8 
  ktimetracker/taskview.cpp 55bc975 
  ktimetracker/timetrackerwidget.cpp d5e482a 

Diff: http://git.reviewboard.kde.org/r/100950/diff


Testing
-------

repeated the 2 flows in the description.


Thanks,

Cristi

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/