[Kde-pim] Re: Review Request: Don't crash while migrating

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100779/#review1834
-----------------------------------------------------------

Ship it!


Looks good to me

- Kevin


On March 2, 2011, 12:10 a.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100779/
> -----------------------------------------------------------
> 
> (Updated March 2, 2011, 12:10 a.m.)
> 
> 
> Review request for KDEPIM and Volker Krause.
> 
> 
> Summary
> -------
> 
> If we add to the list while iterating, the iterator becomes invalid and the application crashes.
> 
> The add is here: mManager->add( clientBridge );
> 
> The patch makes a copy of the list at the beginning.
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/100779/diff
> 
> 
> Testing
> -------
> 
> For some reason review board says it can't find the file to patch, and doesn't accept the diff. I tried kdepim and kdepim-runtime.
> 
> Diff:
> http://paste.pocoo.org/show/346705/
> 
> 
> Thanks,
> 
> Sergio Luis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/