[Kde-pim] Re: Review Request: Bugfix in ImapStreamParser::readParenthesizedList(): don't parse characters inside a quoted-string.

[Gregory Schlomoff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100902/
-----------------------------------------------------------

(Updated March 22, 2011, 3:58 a.m.)


Review request for KDEPIM-Libraries and Kevin Ottens.


Changes
-------

Only skip quoted strings if they are inside a parenthesis subgroup. Otherwise, if we had for example (AA "BB") the previous patch was incorrectly dropping "BB"


Summary
-------

Fixes crashes and errors due to the fact that ImapStreamParser::readParenthesizedList() doesn't recognizes quoted-strings.

Without this fix, if the IMAP server sent the following list: "(AA ("BB)" CC))", ImapStreamParser would crash because it would incorrectly interpret the ")" inside the quoted string "BB)" as part of the list.


Diffs (updated)
-----

  kimap/imapstreamparser.cpp c09baef 

Diff: http://git.reviewboard.kde.org/r/100902/diff


Testing
-------


Thanks,

Gregory

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/