[Kde-pim] Re: Review Request: Provide option to add a custom widget to SingleFileResource config dialog

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101768/
-----------------------------------------------------------

(Updated June 26, 2011, 5:08 p.m.)


Review request for KDEPIM.


Changes
-------

Update diff to include files which will be deleted


Summary
-------

Provide a facility for SingleFileResource derived classes to add a custom widget to the resource config dialog. This is done by providing the new method SingleFileResourceConfigDialog::appendWidget().

In order to simplify the implementation, SingleFileResourceConfigWidget has been merged into SingleFileResourceConfigDialog. (SingleFileResourceConfigWidget is no longer used independently of SingleFileResourceConfigDialog, and this simplifies the code base.)

This facility will be needed by KAlarm.


Diffs (updated)
-----

  resources/CMakeLists.txt 45535a8 
  resources/shared/singlefileresourceconfigdialog.h d9bdd55 
  resources/shared/singlefileresourceconfigdialog_desktop.ui PRE-CREATION 
  resources/shared/singlefileresourceconfigdialog_mobile.ui PRE-CREATION 
  resources/shared/singlefileresourceconfigdialogbase.h 089314c 
  resources/shared/singlefileresourceconfigdialogbase.cpp 4bbf2f9 
  resources/shared/singlefileresourceconfigwidget.h cb4d9f9 
  resources/shared/singlefileresourceconfigwidget.cpp 51ce915 
  resources/shared/singlefileresourceconfigwidget_desktop.ui 83ddaf2 
  resources/shared/singlefileresourceconfigwidget_mobile.ui 17a0888 

Diff: http://git.reviewboard.kde.org/r/101768/diff


Testing
-------

Existing functionality tested by creating and configuring Ical and KDE Account resources.

Tested the new appendWidget() method in KAlarm, using a copy of the proposed kdepim-runtime/resources/shared/


Thanks,

David

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/