[Kde-pim] Re: Review Request: Remove usage of "ExternalPayload" switch

[Volker Krause]

> On June 21, 2011, 12:44 p.m., Andras Mantia wrote:
> > Why remove and not fix the case when payload is stored in the database? Not that I'm not happy that it is not that external payload usage is broken, but the other way around. :)
> 
> Kevin Krammer wrote:
>     You mean option (2) here? http://lists.kde.org/?l=kde-pim&m=130850243326430&w=2

The same behaviour can be achieved by setting the threshold to INT64_MAX, but as we saw, the actual limit imposed by the database is way lower than that anyway, so IMHO this is fine.


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101703/#review4058
-----------------------------------------------------------


On June 20, 2011, 12:03 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101703/
> -----------------------------------------------------------
> 
> (Updated June 20, 2011, 12:03 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> It lead to payload parts not being handled correctly when configured to false. See bug 275561 for an example where changing to true solved with message copying problem and http://lists.kde.org/?t=130850247100005&r=1&w=2 for the discussion
> 
> 
> This addresses bug 275561.
>     http://bugs.kde.org/show_bug.cgi?id=275561
> 
> 
> Diffs
> -----
> 
>   server/src/handler/append.cpp b7b101c 
>   server/src/handler/store.cpp 2021850 
>   server/src/storage/dbconfig.h 0d69cad 
>   server/src/storage/dbconfig.cpp 39fb032 
>   server/src/storage/parthelper.cpp b816393 
> 
> Diff: http://git.reviewboard.kde.org/r/101703/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/