[Kde-pim] Re: Review Request: A developper needs more time to debug an agent.

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101507/#review3689
-----------------------------------------------------------


Two small style changes, then ok from me.


akonadi/agentinstancecreatejob.cpp
<http://git.reviewboard.kde.org/r/101507/#comment3044>

    const QString



akonadi/agentinstancecreatejob.cpp
<http://git.reviewboard.kde.org/r/101507/#comment3045>

    const QString


- Torgny


On June 5, 2011, 2:41 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101507/
> -----------------------------------------------------------
> 
> (Updated June 5, 2011, 2:41 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Volker Krause.
> 
> 
> Summary
> -------
> 
> The informations at:
>   http://techbase.kde.org/Projects/PIM/Akonadi/Development_Tools
>   "Attaching gdb at startup"
> 
> are not sufficiant to debug an agent, because of timeout after the default of 10 seconds.
> 
> Such as "Running an agent in valgrind", the creator of an agent needs to wait longer
> before raising a timeout. If you are a developper, you probably need more time to start
> a debugger, set some breakpoints, and some more actions.
> 
> I propose to use a default value of 150 seconds (the same as "valgrinding") and the option
> to set the value with the environment variable AKONADI_DEBUG_TIMEOUT (value in millisecond).
> 
> 
> Diffs
> -----
> 
>   akonadi/agentinstancecreatejob.cpp 01d04c2 
> 
> Diff: http://git.reviewboard.kde.org/r/101507/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/