[Kde-pim] Re: Review Request: remove 4 memory leaks and one possible null dereference

[Kevin Krammer]

> On June 17, 2011, 8:29 a.m., Kevin Krammer wrote:
> > kresources/kabc/resourceakonadi_p.cpp, line 432
> > <http://git.reviewboard.kde.org/r/101647/diff/1/?file=24583#file24583line432>
> >
> >     the operation above creates a new distribution list. so deleting it right afterwards is wrong.
> >     What was the reason for this change?
> 
> Jaime Torres Amate wrote:
>     I've been programing not in Qt almost 1 year.
>     The remaining question is: how is the distribution list accessed if it's direction is returned to a local pointer?

Th function also adds the list to a look up table (or rather the distribution list's constructor does).
So the return value of the function is not needed.

Your original request said something about fixing problems found by cpptest. what did it find in this particular case?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101647/#review3951
-----------------------------------------------------------


On June 16, 2011, 7:31 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101647/
> -----------------------------------------------------------
> 
> (Updated June 16, 2011, 7:31 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> possible problems found by cppcheck.
> 
> 
> Diffs
> -----
> 
>   kresources/kabc/resourceakonadi_p.cpp 1cecdce 
>   migration/kmail/kmailmigrator.cpp 9f40421 
>   resources/kabc/kabcresource.cpp 926bac4 
> 
> Diff: http://git.reviewboard.kde.org/r/101647/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/