[Kde-pim] Re: Review Request: avoid two possible null pointer dereferences

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101657/#review3988
-----------------------------------------------------------


Looks good now, but I want to check the kabc change more closely before committing.
Btw, make sure indentation is correct, e.g. setName is not on the same column as the closing block brace (could be displayed wrongly on review board, but better check)

- Kevin


On June 17, 2011, 5:30 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101657/
> -----------------------------------------------------------
> 
> (Updated June 17, 2011, 5:30 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Remove two paths for a segfault.
> 
> 
> Diffs
> -----
> 
>   resources/kabc/kabcresource.cpp 926bac4 
>   resources/kcal/kcalresource.cpp cfe5aca 
> 
> Diff: http://git.reviewboard.kde.org/r/101657/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/