[Kde-pim] Re: Review Request: New NoteUtils namespace with NoteMessageWrapper class

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102076/#review5113
-----------------------------------------------------------



akonadi/notes/akonadi-notes_export.h
<http://git.reviewboard.kde.org/r/102076/#comment4591>

    I am flattered but that should probably be you :)



akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4594>

    It might even be possible to forward declare this:
    
    namespace boost {
      template <typename T> class shared_ptr;
    }
    
    namespace KMime {
      class Message;
      typedef boost::shared_ptr<Message> MessagePtr;
    }
    
    And then use KMime::MessagePtr instead of KMime::Message::Ptr



akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4592>

    @since missing (same for stand-alone functions)



akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4593>

    should probably be explicit and const KMime::Message::Ptr&



akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4595>

    Maybe using Qt::TextFormat instead of bool?



akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4596>

    some Qt classes seem to call that one toPlainText() (e.g. QTextEdit, QTextDocument, QGraphicsTextElement)



akonadi/notes/noteutils.cpp
<http://git.reviewboard.kde.org/r/102076/#comment4597>

    Does this also work if you are passing a default constructed KMime::Message::Ptr?


- Kevin


On July 24, 2011, 9:07 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102076/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 9:07 p.m.)
> 
> 
> Review request for Akonadi, KDEPIM-Libraries and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> NoteMessageWrapper is a convenience class to assemble/disassemble Kmime messages into notes(text message).
> This is a first step to standardize how notes are handled with akonadi/akonotes resource.
> 
> The class will be used by the upcoming akonotes-nepomuk-feeder as well as MindMirror.
> (Of course also kjots and any other app working with the akonotes resource might make use of it)
> 
> I put the files in a new notes directory, so we can put there future efforts like an even more convenient Note class,
> which I briefly discussed with skelly.
> 
> The NoteUtils namespace can be used for further note related helper functions/classes.
> 
> As skelly already had a look at it I will commit if noone objects within the next days.
> 
> 
> Diffs
> -----
> 
>   KdepimLibsConfig.cmake.in 3615dd71cf7eeba90d99ac0006c64075cdf38e38 
>   akonadi/CMakeLists.txt cf63a0db5d7139d29cad268cd7aeaaa9a00e3cf1 
>   akonadi/notes/CMakeLists.txt PRE-CREATION 
>   akonadi/notes/akonadi-notes_export.h PRE-CREATION 
>   akonadi/notes/noteutils.h PRE-CREATION 
>   akonadi/notes/noteutils.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102076/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/