[Kde-pim] Re: Review Request: kmail: now it is allowed to create a new folder on the top of an imap folder

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102031/#review5020
-----------------------------------------------------------



resources/imap/addcollectiontask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment4451>

    KJob::exec() is a no-go in resources due to the reentrancy problems it introduces. But why do you need a folder separator for top-level folders at all?



resources/imap/retrievecollectionmetadatatask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment4452>

    This allows creation of folders in all collections, even shared read-only folders of other users or those marked as \NoSelect, no?



resources/imap/retrievecollectionstask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment4453>

    This is wrong nevertheless, the root folder cannot contain mails, so it should not claim it does. Besides, isStructural() should only return true for empty content mime type lists, which is not the case here, it contains Collection::mimeType().



resources/imap/retrievecollectionstask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment4455>

    I think this should be the only really needed change for this. However, I'm unsure what side-effects this has on IMAP servers that have only INBOX at top-level and everything else below that (e.g. Cyrus).



resources/imap/retrievecollectionstask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment4454>

    Why this change? \NoSelect is set on structural folders that don't physically exist, you can't really create sub-folders of those in general.


- Volker


On July 21, 2011, 4:46 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102031/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 4:46 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> On kmail 2, if you try to add a folder under your top imap folder, you will see that the button "Add folder" is disable. This patch is fixing this issue.
> 
> 
> This addresses bug 251704.
>     http://bugs.kde.org/show_bug.cgi?id=251704
> 
> 
> Diffs
> -----
> 
>   resources/imap/addcollectiontask.cpp 5ce6aec 
>   resources/imap/retrievecollectionmetadatatask.cpp 3c9ead4 
>   resources/imap/retrievecollectionstask.cpp 48f0e57 
> 
> Diff: http://git.reviewboard.kde.org/r/102031/diff
> 
> 
> Testing
> -------
> 
> Kdepim and kdepim-runtime compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/