[Kde-pim] Re: Review Request: Not all XML-RPC responses are in UTF-8. Allow QDomDocument to perform character encoding on the server response.

[Robby Stephenson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101838/
-----------------------------------------------------------

(Updated July 3, 2011, 6:02 a.m.)


Review request for KDEPIM-Libraries.


Summary
-------

Not all XML-RPC responses are in UTF-8. Allow QDomDocument to perform character encoding on the server response.


Diffs
-----

  kxmlrpcclient/query.cpp adbf288 

Diff: http://git.reviewboard.kde.org/r/101838/diff


Testing (updated)
-------

Tested using libkxmlrpcclient to access the XML-RPC API for moviemeter.nl (http://wiki.moviemeter.nl/index.php/API) which returns data in iso-8859-15. The API requires registering for an API key, which is why I didn't include a unit test. A film search for "Tropa de Elite 2" would show the bug.


Thanks,

Robby

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/