[Kde-pim] Re: Review Request: Display AntiSpam assitant warning message in a QTextEdit instead of QLabel

Ingo Klöcker kloecker at kde.org
Mon Jul 4 19:41:06 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101824/#review4391
-----------------------------------------------------------

Ship it!


Screenshots for comparing before and after would have been nice. Anyway, the changes look sane.

- Ingo


On July 2, 2011, 5:32 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101824/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 5:32 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Using QTextEdit instead of QLabel as QTextEdit has scrollbar and QLabel does not, this could made part of the text in the Anti-Virus assitant unreadable if font size if big.
> 
> 
> Diffs
> -----
> 
>   kmail/antispamwizard.h d312870 
>   kmail/antispamwizard.cpp 7c99df7 
> 
> Diff: http://git.reviewboard.kde.org/r/101824/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list