[Kde-pim] Review Request: fix assertion in monitoredItemMoved

Milian Wolff mail at milianw.de
Sat Jul 16 20:29:55 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101973/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Summary
-------

fixes an assertion in EntityTreeModelPrivate::monitoredItemMoved which I could reproduce everytime kmail2 was started in conjunction with the rest of my kde session. restarting kmail afterwards worked fine though.

I have lots of filters, maybe it's related.

The assertion was in m_childEntities[].takeAt() due to srcRow == -1 because indexOf apparently did not find the given itemId... No idea whats going on and whether it's bad but at least this way it's not crashing anymore.


This addresses bug 250692.
    http://bugs.kde.org/show_bug.cgi?id=250692


Diffs
-----

  akonadi/entitytreemodel_p.cpp 33354bb 

Diff: http://git.reviewboard.kde.org/r/101973/diff


Testing
-------

restarted KDE, no crash anymore.


Thanks,

Milian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list