[Kde-pim] Re: [kdepim] mailcommon: Fetch header too needs by mailing list

[laurent Montel]

Le Sunday 17 July 2011 11:08:50 Volker Krause a écrit :
> Montel Laurent wrote:
> 
> > Git commit 35cf4a0b31affe46611e934ebb9312fc9fe3411a by Montel Laurent.
> > Committed on 16/07/2011 at 19:06.
> > Pushed by mlaurent into branch 'master'.
> > 
> > Fetch header too needs by mailing list
> > 
> > M  +1    -0    mailcommon/foldercollectionmonitor.cpp
> > 
> > http://commits.kde.org/kdepim/35cf4a0b31affe46611e934ebb9312fc9fe3411a
> > 
> > diff --git a/mailcommon/foldercollectionmonitor.cpp
> > b/mailcommon/foldercollectionmonitor.cpp index c5b6b91..7e819ad 100644
> > --- a/mailcommon/foldercollectionmonitor.cpp
> > +++ b/mailcommon/foldercollectionmonitor.cpp
> > @@ -50,6 +50,7 @@ FolderCollectionMonitor::FolderCollectionMonitor(
> > QObject *parent )
> >    mMonitor->setResourceMonitored( "akonadi_nepomuktag_resource" ,  true
> >    );
> >  #endif
> >    mMonitor->itemFetchScope().fetchPayloadPart(
> >    Akonadi::MessagePart::Envelope );
> > +  mMonitor->itemFetchScope().fetchPayloadPart(
> > Akonadi::MessagePart::Header );
> >  }
> >  
> >  FolderCollectionMonitor::~FolderCollectionMonitor()
> 
> While I'm sure this fixes the mailing list bug to some extend, this looks 
> very problematic for memory usage. This increases the memory use for a 
> folder listing by one order of magnitude with maildir at least, for IMAP it 
> either does this as well or it does not fix the bug (since IMAP might not be 
> retrieving the List-Id header during header listing). 

Ok didn't know pb with memory usage.
Will look at how to fix it.

I hope to find a fix soon. 

Regards.
(But it's right kmail2 has a lot of memory usage so I will avoid to add other pb with memory usage... I will fix it soon I hope)



> So, IMHO this should be reverted, the price is not worth the gain here, and 
> we should find another solution for the mailing list bug. On-demand fetching 
> of the headers would be preferably I guess (either from Akonadi or from 
> Nepomuk). If that's not possible, extending the ENVELOPE part by the List-Id 
> header might be another option, but this would have a memory impact on 
> everything again, for a rather exotic feature.
> 
> regards
> Volker
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/