[Kde-pim] Re: Review Request: Fix custom field handling in KDEPimLibs

[Jan Gerrit Marker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101809/#review4474
-----------------------------------------------------------


Anyone? I'd push it but it is my first contribution to KDEPimLibs so I thought it'd be better to ask before pushing.

- Jan Gerrit


On July 1, 2011, 11:33 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101809/
> -----------------------------------------------------------
> 
> (Updated July 1, 2011, 11:33 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> There where several bugs in the custom field handling of KDEPimLibs (I found them in KAddressbook):
> 1. the type was not loaded correctly when showing a contact's information
> 2. the type of a field was not load correctly when editing a contact
> 3. the global fields where not loaded for a new contact and therefore deleted as the save function deletes all global fields and readds them from the current contact.
> 
> This patch fixes all of them (per bug one line change). I am pretty sure that the first two bugs are fixed properly. The last bug is fixed by loading all global fields in the constructor. If I understood the code correctly that should be okay as all fields are reloaded when loading a contact so no duplicates should occur.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactviewer.cpp 9b0469b 
>   akonadi/contact/customfieldmanager.cpp 90df0b6 
>   akonadi/contact/editor/customfieldseditwidget.cpp e36144b 
> 
> Diff: http://git.reviewboard.kde.org/r/101809/diff
> 
> 
> Testing
> -------
> 
> Tested with a few contacts.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/