[Kde-pim] Re: Review Request: Correctly set the "completed" status on tasks

Grégory Oestreicher greg at kamago.net
Fri Jul 29 14:28:37 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102121/
-----------------------------------------------------------

(Updated July 29, 2011, 1:28 p.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Make KCalCore test #459 pass again.
The previous patch unconditionnaly removed the status  property. Now remove it only if the status must be set to completed.


Summary
-------

This is a port to KCalCore of the patch proposed in bug 171905 (original patch is at https://bugs.kde.org/attachment.cgi?id=28627).


This addresses bug 171905.
    http://bugs.kde.org/show_bug.cgi?id=171905


Diffs (updated)
-----

  kcalcore/icalformat_p.cpp 855c8ed 

Diff: http://git.reviewboard.kde.org/r/102121/diff


Testing
-------

The completed flag is correctly set and interpreted by the remote server (tested with the dav resource).


Thanks,

Grégory

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list