[Kde-pim] Re: Review Request: Correctly set the "completed" status on tasks

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102121/#review5240
-----------------------------------------------------------



kcalcore/icalformat_p.cpp
<http://git.reviewboard.kde.org/r/102121/#comment4730>

    When reading the to-do, I wouldn't do this one. Since it's already done when reading the COMPLETED: or PERCENT-COMPLETED flags.
    
    So it's a bit redundant, and I would prefer not having more than one path that sets the completed flag.
    
    If some software writes the ICAL_STATUS_COMPLETED, but doesn't set the percentage to 100%, then it's broken and should be fixed.


- Sergio Luis


On July 29, 2011, 1:28 p.m., Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102121/
> -----------------------------------------------------------
> 
> (Updated July 29, 2011, 1:28 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> This is a port to KCalCore of the patch proposed in bug 171905 (original patch is at https://bugs.kde.org/attachment.cgi?id=28627).
> 
> 
> This addresses bug 171905.
>     http://bugs.kde.org/show_bug.cgi?id=171905
> 
> 
> Diffs
> -----
> 
>   kcalcore/icalformat_p.cpp 855c8ed 
> 
> Diff: http://git.reviewboard.kde.org/r/102121/diff
> 
> 
> Testing
> -------
> 
> The completed flag is correctly set and interpreted by the remote server (tested with the dav resource).
> 
> 
> Thanks,
> 
> Grégory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/